Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor common functions and command prompt #469

Merged
merged 6 commits into from
Nov 18, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Nov 18, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@mlycore mlycore added this to the 0.4.0 milestone Nov 18, 2023
@github-actions github-actions bot added the pitr solutions of pitr label Nov 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

Attention: 831 lines in your changes are missing coverage. Please review.

Comparison is base (3604a24) 39.71% compared to head (a8c3c9a) 36.69%.
Report is 206 commits behind head on main.

Files Patch % Lines
...phere-operator/pkg/controllers/chaos_controller.go 0.00% 276 Missing ⚠️
...perator/pkg/controllers/storage_node_controller.go 26.58% 96 Missing and 20 partials ⚠️
...operator/pkg/controllers/auto_scaler_controller.go 0.00% 89 Missing ⚠️
pitr/cli/internal/cmd/delete.go 60.80% 38 Missing and 11 partials ⚠️
pitr/cli/internal/pkg/local-storage.go 11.11% 37 Missing and 3 partials ⚠️
pitr/agent/internal/pkg/opengauss.go 2.56% 38 Missing ⚠️
...ator/cmd/shardingsphere-operator/manager/option.go 6.06% 31 Missing ⚠️
pitr/cli/internal/cmd/common.go 77.77% 16 Missing and 8 partials ⚠️
...ere-operator/pkg/kubernetes/container/container.go 31.25% 22 Missing ⚠️
shardingsphere-operator/pkg/kubernetes/helpers.go 46.15% 20 Missing and 1 partial ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   39.71%   36.69%   -3.03%     
==========================================
  Files          51       60       +9     
  Lines        6083     6780     +697     
==========================================
+ Hits         2416     2488      +72     
- Misses       3448     4049     +601     
- Partials      219      243      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mlycore <[email protected]>
Copy link

sonarcloud bot commented Nov 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@terrymanu terrymanu merged commit 8675a64 into apache:main Nov 18, 2023
8 checks passed
@mlycore mlycore deleted the refactor-common branch November 18, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pitr solutions of pitr type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants